[PATCH] D38921: [analyzer] LoopUnrolling: update the matched assignment operators

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/LoopUnrolling.cpp:100
                         declRefExpr(to(varDecl(VarNodeMatcher)))))),
       binaryOperator(anyOf(hasOperatorName("="), hasOperatorName("+="),
                            hasOperatorName("/="), hasOperatorName("*="),
----------------
Maybe instead of enumerating all the assignment operators here it would be 
better to have a matcher that checks `isAssignmentOp` for 
CXXOperatorCalls/BinaryOperators? This would be less error prone and more 
future proof.


https://reviews.llvm.org/D38921



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits