erichkeane added a comment. Additionally, I'm going to edit the 'interrupt' docs in a separate commit to give each a separate header name based on the architecture. Currently they are all named 'interrupt', so I want to rename them all interrupt (x86), etc. Look for a future review!
================ Comment at: utils/TableGen/ClangAttrEmitter.cpp:3666 const Record *Attribute; + std::string Heading; + unsigned SupportedSpellings; ---------------- These two cannot be 'const', otherwise operator= is suppressed. Thus, std::sort won't work (Requires ValueSwappable). ================ Comment at: utils/TableGen/ClangAttrEmitter.cpp:3865 // we can begin to generate sections of documentation. - for (const auto &I : SplitDocs) { + for (auto &I : SplitDocs) { WriteCategoryHeader(I.first, OS); ---------------- Had to remove const, since the sort actually modifies the map. https://reviews.llvm.org/D38969 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits