sdardis added a reviewer: compnerd. sdardis added a subscriber: compnerd. sdardis added a comment.
Two last inlined comments and I think that's everything. @compnerd Have I missed anything? ================ Comment at: src/UnwindRegistersSave.S:100 +# +DEFINE_LIBUNWIND_FUNCTION(unw_getcontext) + .set push ---------------- After looking at another implementation of libunwind and the other platforms that are supported, it seems to me that we need to save all the registers. ================ Comment at: src/UnwindRegistersSave.S:142 +# +DEFINE_LIBUNWIND_FUNCTION(unw_getcontext) + .set push ---------------- Similarly here as well. https://reviews.llvm.org/D38110 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
