ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed.
Also, one more important thing. I'll unaccept revision for now, before getting feedback on this one. ================ Comment at: include/clang/Lex/Preprocessor.h:333 + PreambleSkipInfo SkipInfo; + ---------------- ilya-biryukov wrote: > Maybe move closer to other fields to avoid mixing data and functions? Maybe initialize `SkipInfo` with default values? Or even better: forbid default constructor and put it into `llvm::Optional`? It's a public member, so I guess there's a huge potential some code will eventually get into undefined behavior when using it. https://reviews.llvm.org/D38578 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
