ilya-biryukov accepted this revision.
ilya-biryukov added a comment.

Thanks. LGTM modulo minor NIT (see other inline comment).
Do you need help to land this?



================
Comment at: clangd/GlobalCompilationDatabase.cpp:102
+    if (ReturnValue == nullptr)
+      Logger.log("Failed to find compilation database for " + Twine(File) +
+                 "\n");
----------------
Message should probably mention that's clangd was looking for compile commands 
in an overridden directory.


https://reviews.llvm.org/D37150



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to