ilya-biryukov added a comment. Thanks for the patch, I'll take a closer look a bit later. But just wanted to post one very important comment right away.
================ Comment at: clangd/ClangdUnit.h:268 +std::vector<DocumentHighlight> findDocumentHighlights(ParsedAST &AST, Position Pos, + clangd::Logger &Logger); + ---------------- Please `clang-format` the code on every submission! https://reviews.llvm.org/D38425 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits