aaron.ballman added a comment. > The code for printf diagnostics + new tests are supposed to be added by a > separate diff.
I think you should combine that diff and this one into a single patch, otherwise this patch is untestable. ================ Comment at: include/clang/AST/ASTContext.h:1492-1493 + /// \brief Return the unique unsigned counterpart of + /// "ptrdiff_t" integer type. + QualType getUnsignedPointerDiffType() const; ---------------- Wrap the comment, and you might want to refer to C11 7.21.6.1p7 as a justification for why this is needed. Repository: rL LLVM https://reviews.llvm.org/D38270 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
