martell added a comment. LGTM
we should probably set c++17 as the default over c++14 as part of this change. given that everything seems in order for c++17 bar P0522R0 so this looks like the change should be good. adding @rnk to confirm. @daxpedda do you have commit access? ================ Comment at: test/Driver/cl-options.c:514 // RUN: %clang_cl -fmsc-version=1900 -TP -### -- %s 2>&1 | FileCheck -check-prefix=CXX14 %s // CXX14: -std=c++14 ---------------- We should probably change the default to c++17 as part of this commit. https://reviews.llvm.org/D38123 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
