phst added inline comments.

================
Comment at: tools/clang-format/clang-format.el:125
 If called interactively uses the region or the current statement if there
 is no active region.  If no style is given uses `clang-format-style'."
   (interactive
----------------
Please document the ASSUME-FILE parameter.


================
Comment at: tools/clang-format/clang-format.el:187
 ;;;###autoload
-(defun clang-format-buffer (&optional style)
+(defun clang-format-buffer (&optional style assume-file)
   "Use clang-format to format the current buffer according to STYLE."
----------------
Nit: consider renaming the parameter to ASSUME-FILENAME so that it's clear that 
it's a filename. Same above.


================
Comment at: tools/clang-format/clang-format.el:188
+(defun clang-format-buffer (&optional style assume-file)
   "Use clang-format to format the current buffer according to STYLE."
   (interactive)
----------------
Please document the new parameter here as well.


https://reviews.llvm.org/D37903



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to