malaperle added a comment.
Looks very nice! Just a few questions.
================
Comment at: clangd/ClangdServer.h:24
#include "ClangdUnit.h"
+#include "Logger.h"
#include "Protocol.h"
----------------
forward declare?
================
Comment at: clangd/ClangdUnit.h:13
+#include "Logger.h"
#include "Path.h"
----------------
forward declare?
================
Comment at: clangd/GlobalCompilationDatabase.cpp:88
if (!Error.empty()) {
- // FIXME(ibiryukov): logging
- // Output.log("Error when trying to load compilation database from " +
- // Twine(Path) + ": " + Twine(Error) + "\n");
+ Logger.log("Error when trying to load compilation database from " +
+ Path + ": " + Twine(Error) + "\n");
----------------
Will this log for every parent folder that doesn't contain the compilation
database? I haven't tried to confirm. Just wondering because it could get very
spammy.
================
Comment at: clangd/GlobalCompilationDatabase.h:13
+#include "Logger.h"
#include "Path.h"
----------------
forward declare instead?
https://reviews.llvm.org/D37972
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
