compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Why the additional inclusion of the support in the files which are not modified 
to use functions?  (e.g. `src/stdexcept.cpp`).  LG otherwise.



================
Comment at: src/include/atomic_support.h:150
+_ValueType __libcpp_atomic_exchange(_ValueType* __target,
+                                    _ValueType __value, int __order = _AO_Seq)
+{
----------------
Really annoying that you can't immediately tell that this is in the 
`_LIBCPP_NO_THREADS` case, and thus the atomicity is not required.


https://reviews.llvm.org/D35235



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to