> -----Original Message----- > From: Joerg Sonnenberger via Phabricator [mailto:revi...@reviews.llvm.org] > Sent: Tuesday, September 12, 2017 3:24 PM > To: Blower, Melanie <melanie.blo...@intel.com>; olivier...@gmail.com; > kalinichev.s...@gmail.com; kf...@kde.org; m...@milianw.de; Keane, Erich > <erich.ke...@intel.com>; mgo...@gentoo.org; fedor.v.serg...@gmail.com; > rich...@metafoo.co.uk; renato.go...@linaro.org > Cc: hfin...@anl.gov; jykni...@google.com; ibiryu...@google.com; cfe- > comm...@lists.llvm.org; kli...@google.com; simon.dar...@imgtec.com; > anastasia.stul...@arm.com; arichardson....@gmail.com > Subject: [PATCH] D34158: For Linux/gnu compatibility, preinclude <stdc- > predef.h> if the file is available > > joerg added a comment. > > This version is fine with me. The only contentious part is whether it should > be > opt-in or opt-out for platforms, so getting this version in and revisiting > the issue > again later is OK from my perspective. > > > https://reviews.llvm.org/D34158 > > [Blower, Melanie] That's great news, thank you. Please note there are changes to some clang extra tests needed with this change. The review is here, https://reviews.llvm.org/D34624. You could patch the extra tests before accepting the patch for D34158 (the test changes aren't dependent on D34158). How is platform opt-in accomplished, is it part of the configure step?
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
