ChuanqiXu9 wrote: > We started with a fairly simple change to CodeCompleteModuleImport. Would it > make sense to keep the scope of the PR limited to that, and pursue the > changes discussed in > https://github.com/llvm/llvm-project/pull/187657#issuecomment-4124660898 in a > follow-up PR?
If I understand correctly, this patch is not part of clangd's explicit modules support. But just usable by the design of clangd's implicit modules support. And the bad thing is, currently, CodeCompleteModuleImport here looks not designed for C++20 named modules but for clang header modules IIRC. And of course, the confusing between C++20 named modules and clang header modules is a longstanding design issue in clang. But in the end, I don't feel it is good to deepen the confusing. https://github.com/llvm/llvm-project/pull/187657 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
