cameron314 added a comment.

I'll change the overlay to only allow access to the PCH.

I agree that it would be nice to only read the PCH using real filesystem APIs 
in order to be symmetrical, but this seems non-trivial. It also feels like a 
step in the wrong direction -- ideally the VFS would hold the PCH too instead 
of putting it on disk, in my opinion.

I'm not sure adding a remapped file buffer would work, since it's unclear to me 
exactly at which point the PCH is written relative to the multiple places it's 
read. Additionally, there's code that  does directory traversal in the current 
VFS to find a PCH when given a directory name instead of a file name; this only 
works if the VFS is aware of the PCH, or if the code is rewritten to use the 
underlying file system.


https://reviews.llvm.org/D37474



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to