Sorry about that, thanks for fixing it up for me! Douglas Yung
> -----Original Message----- > From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans > Wennborg > Sent: Wednesday, August 30, 2017 16:28 > To: Yung, Douglas > Cc: cfe-commits > Subject: Re: r312181 - Fix tests for ARM targets > > I fixed them some more in r312193 :-) > > See e.g. here for the sample breakage: > http://bb.pgr.jp/builders/test-clang-i686-linux- > RA/builds/6961/steps/test_clang/logs/Clang%20%3A%3A%20CodeGen__profile-sample- > accurate.c > > On Wed, Aug 30, 2017 at 3:30 PM, Douglas Yung via cfe-commits <cfe- > comm...@lists.llvm.org> wrote: > > Author: dyung > > Date: Wed Aug 30 15:30:08 2017 > > New Revision: 312181 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=312181&view=rev > > Log: > > Fix tests for ARM targets > > > > Tests fail on ARM targets due to ABI name between define and void. Added reg > ex to skip. > > > > Patch by Glenn Howe (and expanded on by Douglas Yung)! > > > > Differential Revision: https://reviews.llvm.org/D33410 > > > > > > Modified: > > cfe/trunk/test/CodeGen/profile-sample-accurate.c > > cfe/trunk/test/CodeGen/thinlto-emit-llvm.c > > cfe/trunk/test/Integration/thinlto_profile_sample_accurate.c > > > > Modified: cfe/trunk/test/CodeGen/profile-sample-accurate.c > > URL: > > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/profile-sam > > ple-accurate.c?rev=312181&r1=312180&r2=312181&view=diff > > ====================================================================== > > ======== > > --- cfe/trunk/test/CodeGen/profile-sample-accurate.c (original) > > +++ cfe/trunk/test/CodeGen/profile-sample-accurate.c Wed Aug 30 > > +++ 15:30:08 2017 > > @@ -1,7 +1,7 @@ > > // Test to ensure -emit-llvm profile-sample-accurate is honored by clang. > > // RUN: %clang -S -emit-llvm %s -fprofile-sample-accurate -o - | > > FileCheck %s > > > > -// CHECK: define void @foo() > > +// CHECK: define {{.*}} void @foo() > > // CHECK: attributes {{.*}} "profile-sample-accurate" > > void foo() { > > } > > > > Modified: cfe/trunk/test/CodeGen/thinlto-emit-llvm.c > > URL: > > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/thinlto-emi > > t-llvm.c?rev=312181&r1=312180&r2=312181&view=diff > > ====================================================================== > > ======== > > --- cfe/trunk/test/CodeGen/thinlto-emit-llvm.c (original) > > +++ cfe/trunk/test/CodeGen/thinlto-emit-llvm.c Wed Aug 30 15:30:08 > > +++ 2017 > > @@ -5,6 +5,6 @@ > > // RUN: %clang_cc1 -O2 -x ir %t.o -fthinlto-index=%t.thinlto.bc > > -emit-llvm -o - | FileCheck %s // RUN: %clang_cc1 -O2 -x ir %t.o > > -fthinlto-index=%t.thinlto.bc -emit-llvm-bc -o - | llvm-dis -o - | > > FileCheck %s > > > > -// CHECK: define void @foo() > > +// CHECK: define {{.*}} void @foo() > > void foo() { > > } > > > > Modified: cfe/trunk/test/Integration/thinlto_profile_sample_accurate.c > > URL: > > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Integration/thinlto > > _profile_sample_accurate.c?rev=312181&r1=312180&r2=312181&view=diff > > ====================================================================== > > ======== > > --- cfe/trunk/test/Integration/thinlto_profile_sample_accurate.c > > (original) > > +++ cfe/trunk/test/Integration/thinlto_profile_sample_accurate.c Wed > > +++ Aug 30 15:30:08 2017 > > @@ -3,7 +3,7 @@ > > // RUN: llvm-lto -thinlto -o %t %t.o > > // RUN: %clang_cc1 -O2 -x ir %t.o -fthinlto-index=%t.thinlto.bc > > -emit-llvm -o - | FileCheck %s > > > > -// CHECK: define void @foo() > > +// CHECK: define {{.*}} void @foo() > > // CHECK: attributes {{.*}} "profile-sample-accurate" > > void foo() { > > } > > > > > > _______________________________________________ > > cfe-commits mailing list > > cfe-commits@lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
