aaron.ballman added inline comments.
================ Comment at: include/clang/Basic/Attr.td:2477 let Spellings = [Declspec<"selectany">, GCC<"selectany">]; let Documentation = [Undocumented]; } ---------------- Prazek wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > Since we're drastically modifying what platforms this is supported on, > > > can you please add documentation for this attribute? > > This documentation isn't correct. Please see the other attributes (and > > AttrDocs.td) for an example of how to add the documentation. > Yes, sorry for that. I haven't compile it before sending patch. Is the > documentation string good at least? It's a good start, though a bit terse. It would help to describe what's happening, perhaps even with a short code example. Also, if GCC has good documentation for it, you can also include a link to GCC's documentation a la, "for more information, see: <link>". https://reviews.llvm.org/D33852 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
