rsmith added inline comments.
================ Comment at: lib/Sema/SemaExpr.cpp:727-728 + // promote to double. + // Note that there is default argument promotion for '_Float16'; this + // applies to the standard floating types only. const BuiltinType *BTy = Ty->getAs<BuiltinType>(); ---------------- Do you mean "there is no default argument promotion for '_Float16'"? I think you could be even more specific: default argument promotion applies only to `float`. (And apparently to `__half` / `__fp16`.) ================ Comment at: test/Frontend/float16.cpp:1-2 +// RUN: %clang_cc1 -std=c++11 -ast-dump %s | FileCheck %s +// RUN: %clang_cc1 -std=c++11 -ast-dump -fnative-half-type %s | FileCheck %s --check-prefix=CHECK-NATIVE + ---------------- If you're going to check the tree structure from an AST dump, you should turn on --strict-whitespace in FileCheck. https://reviews.llvm.org/D33719 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
