vadikmironov wrote:

> LGTM after fixing the formatting issue :) Thank you!
> 
> Optional Nit: It would be nice if you could update the PR description. The 
> current body reads as if it were (at least in part) generated by an LLM. IMHO 
> this might be too verbose and bring in unnecessary noise (as the change in 
> code logic is pretty straightforward). But this is a non-blocking suggestion, 
> you can ignore this if you want.
> 
> In our AI policy:
> 
> > To ensure sufficient self review and understanding of the work, it is 
> > strongly recommended that contributors write PR descriptions themselves (if 
> > needed, using tools for translation or copy-editing).

Fine, fine 😄  While I am at it, I ventured a guess at what might have been a 
reason for a radical drop in incidence of this issue as a response @localspook 
's comments.

https://github.com/llvm/llvm-project/pull/184022
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to