kcc added inline comments.
================
Comment at: clang/lib/Driver/SanitizerArgs.cpp:297
CoverageTraceCmp | CoveragePCTable;
+#if !defined(__APPLE__)
+ // Due to TLS differences, stack depth tracking is disabled on Mac.
----------------
please use if(SomeCondition) instead of #if
In general: 99% of cases where you may want to use #if -- you shouldn't
================
Comment at:
compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cc:20
#include "sanitizer_symbolizer.h"
+#include <cstdint>
----------------
no standard hearder in this files. Just use the 'uptr' type.
https://reviews.llvm.org/D37156
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
