arphaman added inline comments.

================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:537
+
+#include "../../AST/DeclDataCollectors.inc"
+
----------------
I didn't realize that you're including files from within `lib`. That's not 
ideal. You should add a pre-commit that moves the *.inc files over to 
include/AST (and marks them as textual in Clang's `module.modulemap`). Then you 
should include them using the clang/AST path.


https://reviews.llvm.org/D37001



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D37001: [cla... Alex Lorenz via Phabricator via cfe-commits

Reply via email to