================ @@ -0,0 +1,94 @@ +//===- JSONEntitySummaryEncoding.cpp --------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "JSONEntitySummaryEncoding.h" +#include "JSONFormatImpl.h" + +namespace clang::ssaf { + +llvm::Expected<bool> JSONEntitySummaryEncoding::patchEntityIdObject( ---------------- steakhal wrote:
The name of this should signify that it might fail. I think of using the "try" name prefix. It's also very unfortunate that we need a 16 byte return type of a couple bits-wrorth of information. - Pessimizing the happy path for the error path. Maybe if we would delay the materialization of the errors themselves, we could make the return type fit into a single register. I expect this code on the hot path. I'd need to think about this. Maybe not even necessary right now. I'd maybe add that the failure cases will be quickly propagated up and just error out, right? If so, we could mark those branches `LLVM_UNLIKELY`because we dont care about them. https://github.com/llvm/llvm-project/pull/184713 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
