arphaman added inline comments.
================ Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:73 public: + /// Empty (invalid) SyntaxTree. + SyntaxTree(); ---------------- Why do you need to create an empty tree? What about using llvm::Optional instead? ================ Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:82 + SyntaxTree(SyntaxTree &&Other); + SyntaxTree &operator=(SyntaxTree &&Other); + explicit SyntaxTree(const SyntaxTree &Other); ---------------- It's fine to have = default in the header https://reviews.llvm.org/D37005 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
