https://github.com/jeanPerier commented:
Thank you for addressing my comments. Just a minor comment about the cloning of the host link defining op that should be turned into a pass error, LGTM otherwise. Just an FYI, I opened an issue about [trampoline lifetimes](https://github.com/llvm/llvm-project/issues/184377), this is orthogonal to you patch I think, but trampoline for internal procedures should always be created inside the host to comply with the Fortran standard requirements for the lifetime of pointer associations to internal procedures. I think this part needs to be dealt with by emitting the emboxproc in the host in lowering, so again, should be orthogonal to what you are doing, unless we somehow update the logic you have to use the host link address as the cleanup key, in which case the trampoline could still be created inside internal procedures when needed and cleaned-up at the end of the host scope, but that likely has more runtime overhead than modifying the lowering. https://github.com/llvm/llvm-project/pull/183108 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
