================
@@ -46,6 +46,14 @@ AST_MATCHER(ParmVarDecl, isTemplateTypeParameter) {
 
   const QualType ParamType =
       Node.getType().getNonPackExpansionType()->getPointeeType();
+
+  // Explicit object parameters with a type constraint are not forwarding
----------------
zeyi2 wrote:

Sorry for the push back, but this comment seems inaccurate:

> A [forwarding 
> reference](https://eel.is/c++draft/temp.deduct.call#def:forwarding_reference) 
> is an rvalue reference to a cv-unqualified template parameter that does not 
> represent a template parameter of a class template.

Constraints are not mentioned as a disqualifying condition. Would you please 
update the comments? Same as the PR description.

Also, since it introduces new FNs, maybe worth adding a `// FIXME:` or `// 
TODO` comment, WDYT?

https://github.com/llvm/llvm-project/pull/182038
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to