dzbarsky wrote: > I'd like to avoid changing all the tests and also potentially breaking > downstream users who rely on the old flag spelling. I also don't think it's > necessary. For example, rather than changing all instances of `-output=` to > `--output=`, you can simply define the option as: > > ``` > def output : JoinedOrSeparate<["-", "--"], "output", > [Show, Order, Overlap, Merge]>, > MetaVarName<"<output>">, > HelpText<"Output file">; > ```
OK, I can undo that, that's what I had done originally but then changed to the current approach based off your comment here https://github.com/llvm/llvm-project/pull/177868#issuecomment-3822124153 since the other PRs also made similar changes. I'll revert these buts, but it would be great to avoid more confusion/ping-ponging here, especially given the time between review cycles :) https://github.com/llvm/llvm-project/pull/177868 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
