yonghong-song wrote:

I just pushed a new commit with the following change to cover the missing test 
case in ModuleSummaryIndexYAML.h.

```
diff --git a/llvm/test/Transforms/WholeProgramDevirt/Inputs/import-indir.yaml 
b/llvm/test/Transforms/WholeProgramDevirt/Inputs/import-indir.yaml
index 97688cc6d8fc..c168844ac4e7 100644
--- a/llvm/test/Transforms/WholeProgramDevirt/Inputs/import-indir.yaml
+++ b/llvm/test/Transforms/WholeProgramDevirt/Inputs/import-indir.yaml
@@ -26,7 +26,7 @@ GlobalValueMap:
   43:
     - Live: true
       ImportType : 1
-      NoRenameOnPromotion: true
+      NoRenameOnPromotion: false
 TypeIdMap:
   typeid1:
     WPDRes:
diff --git a/llvm/test/Transforms/WholeProgramDevirt/import-indir.ll 
b/llvm/test/Transforms/WholeProgramDevirt/import-indir.ll
index 779ca8f69028..79387f053772 100644
--- a/llvm/test/Transforms/WholeProgramDevirt/import-indir.ll
+++ b/llvm/test/Transforms/WholeProgramDevirt/import-indir.ll
@@ -40,7 +40,7 @@
 ; SUMMARY-NEXT:     Local:                 false
 ; SUMMARY-NEXT:     CanAutoHide:           false
 ; SUMMARY-NEXT:     ImportType:            1
-; SUMMARY-NEXT:     NoRenameOnPromotion:   true
+; SUMMARY-NEXT:     NoRenameOnPromotion:   false
 ; SUMMARY-NEXT: TypeIdMap:
 ; SUMMARY-NEXT:   typeid1:
 ; SUMMARY-NEXT:     TTRes:
 ```
 
The commit message:

```
      - For test import-indir.ll, modify Inputs/import-indir.yaml to
        have different values for ImportType and NoRenameOnPromotion.
        ImportType is 1 and NoRenameOnPromotion is false.
        This can detect previous commit error where NoRenameOnPromotion is
        misplaced in ModuleSummaryIndexYAML.h.
    
        Without previous commit fix, the result YAML will show
        ImportType is 0 and NoRenameOnPromotion is true, which will
        be different from the correct output.
```

https://github.com/llvm/llvm-project/pull/183793
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to