teresajohnson wrote: > Thanks @teresajohnson Just updated a new revision to address your comments: - > Rename DisableAlwaysRenamePromotedLocals back to AlwaysRenamePromotedLocals. > - Add more description for new tests. - Add comments to explain usage of > ExternallyVisibleSymbolNamesPtr.
lgtm, thanks for the patch and working through the iterative review process! > Regarding the force-push. Typically before pushing a new revision, I rebase > on top of 'main' branch so the pull request is close to the 'main' branch. > But unfortunately, once I did rebase, I have to do force-push. Otherwise git > won't allow me to push the pull request. You only need to do this once, when then PR is approved and ready to submit though. You should be able to push to your fork without force pushing, and with your fork being behind main. See https://llvm.org/docs/GitHub.html#pull-requests for the expected flow. https://github.com/llvm/llvm-project/pull/178587 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
