steakhal wrote: > > > This enables executing all test cases with the `REQUIRES: z3` tag via the > > > `check-clang-analysis-z3` target. > > > > > > I like the move, but I didn't get what you are saying here. Where is the > > logic adding the `check-clang-analysis-z3` target and how are the tests > > skipped under that directory if the `REQUIRES: z3` is not satisfied? > > The `check-clang-analysis-z3` target already exists (automatically added for > subdirectories by function `add_lit_testsuites` in > `llvm/cmake/modules/AddLLVM.cmake`), but it will only execute the tests in > the `Analysis/z3/` subdirectory. With this move, all z3-related tests can be > run directly with this target. > > > We can move the missing-z3-nocrash.c under the z3 directory. > > The explanation above is also why I did not move this file: when building the > `check-clang-analysis-z3` target, it will always get skipped as > 'UNSUPPORTED'. Or, do you mean the `check-clang-analysis-z3` target can also > be used to check the `UNSUPPORTED: z3` tests when Z3 is disabled? This is > also reasonable to me. If so, should I also move the other two, i.e., > `print-ranges.cpp` and `PR24184.cpp`? > > > You should probably drop the no-z3 logic and use UNSUPPORTED: z3 instead. > > Nice catch. > > I will do this for `missing-z3-nocrash.c`. But together with removing the > `no-z3` feature in `clang/test/lit.cfg.py`?
I didn't know about this build target. I think your judgment and decisions are correct and makes sense. https://github.com/llvm/llvm-project/pull/183724 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
