================
@@ -539,6 +539,9 @@ class TrivialFunctionAnalysisVisitor
       if (R->hasDefinition() && R->hasTrivialDestructor())
----------------
steakhal wrote:

I think I got what's going on. I'm constantly confused about these terms: 
"clang trivial" means what "trivial" means in C++ (no sideeffects, no 
destruction needed).
"webkit trivial" means no `operator delete` are called.

This means that "clang trivial" **implies** "webkit trivial", but not the other 
way around.

In our case, of course none of the tests would be "clang trivial" because 
almost all has user-defined dtors (thus they are nontrivial in the C++ sense).

I think choosing "trivial" for the program property "webkit trivial" was a poor 
choice because of this. But hopefully I won't be confused about it anymore.

https://github.com/llvm/llvm-project/pull/183711
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to