aviralg wrote: > I have a weak rejection on this one. There are parts that are NFC, and some > others like changing the error messages and stuff like that are non-NFC. > > I'd much prefer having these merged separately.
Normally, I would create separate PRs but @jkorous-apple is out and I didn't want to spend more than a day on this or get into stacked-PR situations for trivial changes like these. I am working on a significant refactor to `JSONFormat` (`TUSummaryEncoding` support) that relies on all these changes being in place, so I didn't want to wait till next week for these changes to go in either. https://github.com/llvm/llvm-project/pull/183390 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
