teresajohnson wrote: > @nikic I think I've addressed the gold plugin issue. I'm not totally happy > with the extra bits in LTO.cpp for `runThinLTO()`, but I don't think there's > much more we can do w/o redesigning a big chunk of this code. > > @teresajohnson the gold plugin did expose a path that the default triple > seems to have tripped us up w/ the combined module. I opted for the fallback > logic used elsewhere, but if there's a better way to solve it aside from a > massive rewrite, I'm all ears.
I see that we normally are setting the triple in the combined module in LTO::add, if it isn't set yet. gold-plugin.cpp calls this too. Do you know why it isn't getting set in the case you looked at? https://github.com/llvm/llvm-project/pull/179509 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
