teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
Found one more minor comment typo. And could you do your changes to `OptParserEmitter.cpp` all in this patch? Because Rui/Me pointed out those things on this review, so this patch should also fix them IMHO :) Otherwise this is good to go, nice work! ================ Comment at: llvm/include/llvm/Option/OptTable.h:152 + /// "foo, bar..", where foo and bar is the argument which the Option flag + // takes + /// ---------------- `///` instead of `//`. https://reviews.llvm.org/D36782 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits