================ @@ -2,14 +2,23 @@ set(LLVM_LINK_COMPONENTS Core Object ProfileData + Option Support ) +set(LLVM_TARGET_DEFINITIONS Opts.td) +tablegen(LLVM Opts.inc -gen-opt-parser-defs) +add_public_tablegen_target(ProfdataOptsTableGen) + add_llvm_tool(llvm-profdata llvm-profdata.cpp DEPENDS intrinsics_gen + ProfdataOptsTableGen + GENERATE_DRIVER ) -target_link_libraries(llvm-profdata PRIVATE LLVMDebuginfod) +if(NOT LLVM_TOOL_LLVM_DRIVER_BUILD) ---------------- dzbarsky wrote:
I'm generally a fan of breaking out changes, but my experience with submitting PRs to LLVM has been extremely high variance in review latency and it's often unclear who to loop in to do reviews, etc, which incentivizes bundling changes to minimize number of times contributor goes through this process :) If you or someone else commits to doing a quick follow-up review enabling the multicall bits, I'll happily split them out https://github.com/llvm/llvm-project/pull/177868 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
