hintonda added a comment.

In https://reviews.llvm.org/D36857#845465, @thakis wrote:

> Oh, I guess this is superseded by https://reviews.llvm.org/D36860 ?


Yes, please ignore this patch -- it was just for brainstorming...  ;-)



================
Comment at: lib/Driver/ToolChains/MSVC.cpp:135
+      llvm::SmallString<256> TestPath = PathEntry;
+      while(!TestPath.empty()) {
         TestPath = llvm::sys::path::parent_path(TestPath);
----------------
thakis wrote:
> Having a while loop going up the directory tree stating around on every 
> compiler invocation for supporting a fairly narrow use case seems a bit 
> unfortunate. Maybe we could instead add a flag (or just a cc1 flag, even) to 
> override the check instead?
Agreed, this patch was abandoned...


https://reviews.llvm.org/D36857



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to