[PATCH] D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure

[don hinton via Phabricator via cfe-commits]

hintonda added a comment.

Looks good, but I'll defer to the owners.

Minor nit...



================
Comment at: lib/Driver/ToolChains/MSVC.cpp:142
           return true;
+        } else if (llvm::sys::path::filename(ParentPath) == "x86ret"
+            || llvm::sys::path::filename(ParentPath) == "x86chk"
----------------
Perhaps remove the else and grab the subdir name only once before doing 
comparisons.


https://reviews.llvm.org/D36860



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits