sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land.
LGTM with comment addressed. ================ Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:328 +mips::IEEE754Standard mips::getIEEE754Standard(StringRef &CPU) { + // Strictly speaking, mips32r2 and mips64r2 are not in accordance to standard + // from 2008, it was first introduced in Release 3. However, other compilers ---------------- "are not in accordance to standard from 2008, it was first introduced in Release 3." This should read: "do not conform to the IEEE754-2008 standard. Support for this standard was first introduced in Release 3." Repository: rL LLVM https://reviews.llvm.org/D36824 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits