ilya-biryukov added a comment.

In https://reviews.llvm.org/D35200#844132, @yvvan wrote:

> The files might also be removed.
>  I checked that with qtcreator from git. Switching to the different branch 
> started reparse of some files.
>  When I frequently switched branches back and forth I got lock issues. With 
> mmap turned off this did not happen.


Renaming/removing memory mapped files also works fine.

What were those 'lock issues' specifically? `MemoryBuffer` code that uses the 
function you're changing seems to be doing the right thing by always allowing 
shared file access.
We definitely need a test case that realiably reproduces your issue.


https://reviews.llvm.org/D35200



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to