arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:738 + } + double Denominator = T1.getNumberOfDescendants(Id1) - 1 + + T2.getNumberOfDescendants(Id2) - 1 - CommonDescendants; ---------------- Can denominator even be negative here? If no, please assert correspondingly. https://reviews.llvm.org/D36185 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits