https://github.com/hubert-reinterpretcast commented:

Initial comments:
- The test should target the array cases to arrays where the bound is known.
- The PR title should say something like "precommit tests for eventual [...]" 
instead of "add coverage for [...]".
- The PR title/description should cover array out-of-bounds checking.
  - There should already be array out-of-bounds checking under the status quo; 
however, the planned fix will (at least for a subset of the cases) modify the 
checking to also trigger for the case where the indexing generates the 
past-the-end pointer.

https://github.com/llvm/llvm-project/pull/176210
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to