================
@@ -453,14 +454,15 @@ def main():
         "--creduce",
         dest="creduce",
         type=str,
-        help="The path to the `creduce` executable. "
-        "Required if `creduce` is not in PATH environment.",
+        help="The path to the `creduce` or `cvise` executable. "
+        "Required if neither `creduce` nor `cvise` are on PATH.",
     )
     parser.add_argument("-v", "--verbose", action="store_true")
     args, creduce_flags = parser.parse_known_args()
     verbose = args.verbose
     llvm_bin = os.path.abspath(args.llvm_bin) if args.llvm_bin else None
     creduce_cmd = check_cmd("creduce", None, args.creduce)
+    creduce_cmd = check_cmd("cvise", None, args.creduce)
----------------
nico wrote:

Doesn't this unconditionally overwrite the previous line? Is the intent that 
this script hard-fails if cvise isn't present, or was this supposed to become 
something like

```
    creduce_cmd = check_cmd("cvise", None, args.creduce)
    if not creduce_cmd:
        creduce_cmd = check_cmd("creduce", None, args.creduce)
```


https://github.com/llvm/llvm-project/pull/128592
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to