dexonsmith added a comment. Oh, also found a couple of things you should likely split into prep commits to simplify this patch.
================ Comment at: src/cxa_demangle.cpp:1575-1577 - sub_type names; - template_param_type subs; - Vector<template_param_type> template_param; ---------------- - Why not rename `names` as well? - Please rename these in a separate prep commit to minimize noise on the final patch. https://reviews.llvm.org/D36427 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
