delesley added a comment. Overall looks good. However, I would change the wording on the warning to the following. The terms "free function" and "instance method" may be confusing to some people. Also, warn_thread_attribute_noargs_static_method should not mention the capability attribute, which is checked separately in warn_thread_attribute_noargs_not_lockable.
def warn_thread_attribute_noargs_not_method: ... "%0 attribute without arguments can only be applied to a method of a class." ... def warn_thread_attribute_noargs_static_method: ... "%0 attribute without arguments cannot be applied a static method." ... https://reviews.llvm.org/D36237 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
