================
@@ -24,7 +24,7 @@ namespace clang::tidy {
/// them in the order of appearance in the list.
class GlobList {
public:
- virtual ~GlobList() = default;
+ GlobList() = default;
----------------
vbvictor wrote:
There could be downstream users that use this class differently or we can try
to use it is something else in far future (lets say 5-10 years). When future
people will use it, they will be surprised to see this (or get a bug).
I think this change will not affect real-world clang-tidy performance, but it
brings less maintainable code, so It's a net-negative change.
https://github.com/llvm/llvm-project/pull/164212
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
