timon-ul wrote:

> Things already fail at the SymbolCollector level

Holy how the heck did you figure that one out. I was pretty lost where to even 
look or how to reproduce the issue. Even now I do not understand how to 
reproduce that really. I mean initially I had set up a 2 cpp 1 hpp file setup 
for this reason, because I was considering something like this might be the 
issue but it still worked. Now with your insight I thought the problem might be 
parrallel indexing so I gave clangd only 1 thread but it still finds both.

> The relevant logic for skipping function bodies is 
> [here](https://searchfox.org/llvm/rev/42b3483ac4987cae1bdb632398e8a3ce2dea6633/clang-tools-extra/clangd/index/IndexAction.cpp#143-153)

Ah, a familiar place. Neat that we have access to the `SymbolCollector` here, 
means we can use the cache and don't need to call `isLikelyForwardingFunction` 
twice.

https://github.com/llvm/llvm-project/pull/169742
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to