github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp --
clang-tools-extra/clang-tidy/performance/ReplaceWithStringViewCheck.cpp
clang-tools-extra/clang-tidy/performance/ReplaceWithStringViewCheck.h
clang-tools-extra/test/clang-tidy/checkers/performance/replace-with-string-view.cpp
clang-tools-extra/clang-tidy/performance/PerformanceTidyModule.cpp
--diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git
a/clang-tools-extra/clang-tidy/performance/ReplaceWithStringViewCheck.cpp
b/clang-tools-extra/clang-tidy/performance/ReplaceWithStringViewCheck.cpp
index 55978bec7..e97c53ec2 100644
--- a/clang-tools-extra/clang-tidy/performance/ReplaceWithStringViewCheck.cpp
+++ b/clang-tools-extra/clang-tidy/performance/ReplaceWithStringViewCheck.cpp
@@ -54,22 +54,22 @@ void
ReplaceWithStringViewCheck::registerMatchers(MatchFinder *Finder) {
void ReplaceWithStringViewCheck::check(const MatchFinder::MatchResult &Result)
{
const auto *MatchedDecl = Result.Nodes.getNodeAs<FunctionDecl>("func");
assert(MatchedDecl);
- const llvm::StringLiteral DestReturnTypeStr =
- toStringViewTypeStr(MatchedDecl->getReturnType()
- .getDesugaredType(*Result.Context)
- .getAsString());
+ const llvm::StringLiteral DestReturnTypeStr =
+ toStringViewTypeStr(MatchedDecl->getReturnType()
+ .getDesugaredType(*Result.Context)
+ .getAsString());
- auto Diag = diag(MatchedDecl->getReturnTypeSourceRange().getBegin(),
- "consider using '%0' to avoid unnecessary "
- "copying and allocations")
- << DestReturnTypeStr << MatchedDecl;
+ auto Diag = diag(MatchedDecl->getReturnTypeSourceRange().getBegin(),
+ "consider using '%0' to avoid unnecessary "
+ "copying and allocations")
+ << DestReturnTypeStr << MatchedDecl;
- for (const auto *FuncDecl = MatchedDecl; FuncDecl != nullptr;
- FuncDecl = FuncDecl->getPreviousDecl()) {
- Diag <<
FixItHint::CreateReplacement(FuncDecl->getReturnTypeSourceRange(),
- DestReturnTypeStr);
- }
+ for (const auto *FuncDecl = MatchedDecl; FuncDecl != nullptr;
+ FuncDecl = FuncDecl->getPreviousDecl()) {
+ Diag << FixItHint::CreateReplacement(FuncDecl->getReturnTypeSourceRange(),
+ DestReturnTypeStr);
}
}
+}
} // namespace clang::tidy::performance
``````````
</details>
https://github.com/llvm/llvm-project/pull/172170
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits