Lancern wrote: I have rebased my patch in the incubator. I do spot a few non-trivial differences between this patch and my patch, and I'm listing them here.
1. I realized that `CIRGenericABILoweringPattern` is not general enough because it did not handle operations with nested regions, and this is causing tests to fail in the incubator because nested regions were added to operations such as `cir.call`, which was not covered by the old patch. I updated `CIRGenericABILoweringPattern` in the incubator so that it now handles nested regions. 2. The incubator puts ABILowering after LoweringPrepare in the pass pipeline, while this patch puts ABILowering before LoweringPrepare. I cannot immediately see which one is better but I believe some discussions might happen for this. https://github.com/llvm/llvm-project/pull/172133 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
