================
@@ -16412,28 +16438,53 @@ Decl *Sema::ActOnFinishFunctionBody(Decl *dcl, Stmt
*Body, bool IsInstantiation,
FD->getAttr<SYCLKernelEntryPointAttr>();
if (FD->isDefaulted()) {
Diag(SKEPAttr->getLocation(), diag::err_sycl_entry_point_invalid)
- << SKEPAttr << /*defaulted function*/ 3;
+ << SKEPAttr << /*defaulted function*/ 2;
----------------
tahonermann wrote:
The challenge is always where to declare the enumeration. I would prefer to
separate the diagnostics rather than introduce additional declarations for the
sole purpose of specifying a selection argument. I understand that there has
been some sentiment expressed in the past for avoiding duplicated subtext in
diagnostics to ease future translation, but I think that advice is misplaced;
modern translation may require alterations to the non-substituted text to align
with substituted fields (and in more ways than simple plural handling).
Either way, I would prefer to make such a change as a separate PR. I would be
ok with landing that PR first and then rebasing this PR on top of it.
https://github.com/llvm/llvm-project/pull/152403
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
