================
@@ -448,6 +452,10 @@ class MetadataLoader::MetadataLoaderImpl {
   /// metadata.
   SmallDenseMap<Function *, DISubprogram *, 16> FunctionsWithSPs;
 
+  /// retainedNodes of these subprograms should be cleaned up from incorrectly
+  /// scoped local types.
----------------
jmorse wrote:

IMO to avoid confusing future readers, we need to signal something about the 
fact that it's LLVM/ORDUniquing that's causing things to be invalid, not the 
input. Possibly "See the comment on \ref DISubprogram::cleanupRetainedNodes"?

https://github.com/llvm/llvm-project/pull/165032
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to