https://github.com/shafik commented:
It looks reasonable but since this is ostensiably about `std::byte` we should have a test that verifies this does what we expect w/ `std::byte`. Yes, it should be an enum but if it fails in the future then we know we have a problem. We need to write tests that explicitly test what we want and not base them on assumptions that can be regressed by future changes. https://github.com/llvm/llvm-project/pull/169079 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
