================
@@ -4595,7 +4598,14 @@ void Driver::BuildDefaultActions(Compilation &C,
DerivedArgList &Args,
LA->propagateHostOffloadInfo(C.getActiveOffloadKinds(),
/*BoundArch=*/nullptr);
} else {
- LA = C.MakeAction<LinkJobAction>(LinkerInputs, types::TY_Image);
+ // If we are linking but were passed -emit-llvm, we will be calling
----------------
mgcarrasco wrote:
I understand your point that based on the test cases, at the moment, the SPIRV
TC seems to be the only one that exercises the `types::TY_LLVM_BC` case.
However, this is in the driver and it can potentially be exercised by other new
or untested compilation paths. I don't have enough context on the driver to
know if it is appropriate to always make the `LinkJobAction` emit bitcode for
`-emit-llvm` other than the SPIRV TC case.
How would the condition be to restrict these changes only to your scenario?
Perhaps at the cost of readability that is the safest path to take.
https://github.com/llvm/llvm-project/pull/169572
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
